WIP: feat/firestore-notification-backend #25

Closed

A8065384 wants to merge 2 commits from feat/firestore-notification-backend into main

pull from: feat/firestore-notification-backend

merge into: va:main

va:main

va:feature/before-guardrail

va:issue/session

Conversation 0 Commits 2 Files Changed 9 +421 -149

A8065384 commented 2026-03-09 06:42:10 +00:00

Owner

Copy Link

No description provided.

A8065384 added 2 commits 2026-03-09 06:42:11 +00:00

Add Notification Backend Protocol 2370d7de96

feat: switch notification backend from Redis to Firestore ... 9f4edcb04a

- Refactor FirestoreNotificationBackend to use time-gated window
  (window_hours) instead of notified_by_agent status filtering;
  mark_as_notified is now a no-op (agent is awareness-only).
- Update agent.py to instantiate FirestoreNotificationBackend using the
  shared firestore_db client instead of RedisNotificationBackend.
- Remove redis_host/redis_port settings from config.py; add
  notifications_collection_path, max_to_notify, and window_hours.
- Move redis/json imports inside RedisNotificationBackend methods so
  redis is only required if that backend is explicitly instantiated.
- Add utility scripts for checking and registering notifications.
- Add google-cloud-firestore dependency to pyproject.toml.

A8065384 closed this pull request 2026-03-09 06:47:46 +00:00

A8065384 deleted branch feat/firestore-notification-backend 2026-03-09 06:47:46 +00:00

Some checks failed

Hide all checks

CI / ci (pull_request) Failing after 1m40s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

A8065384 A8072846 A8080816

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: va/agent#25